Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove menu options for disabled features #1145

Conversation

bruno-atmire
Copy link
Contributor

@bruno-atmire bruno-atmire commented May 4, 2021

References

Fixes #1125
Fixes #1019 (by removing disabled features)
Fixes #1155 (by removing disabled features)

Description

  • Removed duplicate curation_tasks menu item because it would be overridden by this item anyway.
  • Commented out all menu items that currently don't have a link defined.

Instructions for Reviewers

Log into DSpace and verify that all disabled menu items are gone from the sidebar.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@artlowel artlowel added 1 APPROVAL pull request only requires a single approval to merge bug component: administrative tools Related to the admin menu or tools e/1 Estimate in hours medium priority testathon Reported by a tester during Community Testathon labels May 4, 2021
@artlowel artlowel added this to the 7.0 milestone May 4, 2021
@tdonohue tdonohue self-requested a review May 6, 2021 14:56
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me, thanks @bruno-atmire ! I gave it a quick test and it works as expected...no more disabled features are shown in the sidebar.

@tdonohue tdonohue merged commit 5f87d69 into DSpace:main May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: administrative tools Related to the admin menu or tools e/1 Estimate in hours medium priority testathon Reported by a tester during Community Testathon
Projects
None yet
3 participants