-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix item-level statistics pages #1182
Fix item-level statistics pages #1182
Conversation
This pull request introduces 9 alerts when merging 6631980 into a87bf00 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YanaDePauw : The code here looks good & it fixes the bug. However, I was a little surprised to see no specs/tests in this PR. Is there any way we could add a spec or two to make sure this same sort of problem doesn't happen again later? (If for some reason that's overly complex we could add a ticket for this...but I'm hoping it's simple enough to add to this PR)
This pull request introduces 1 alert when merging 926dd46 into 68bd8d4 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 579f98d into 68bd8d4 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @YanaDePauw for adding some new e2e tests here. This all looks good now!
References
Fixes #1116
Description
This PR fixes the issue with navigating to the statistics page from an item where the user got redirected to the item page instead of going to the statistics page.
Instructions for Reviewers
Checklist
yarn run lint
package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.