Workflow rejection reasons are not properly encoded

[bruno-atmire]

References

• Fixes Workflow rejection reasons are not properly encoded #1224

Description

Encode each segment that comes from the function's inputs separately with encodeURIComponent, instead of once at the end with encodeURI.

Instructions for Reviewers

See #1224 for steps on how to test.

List of changes in this PR:

• do proper uri encoding in requestService.uriEncodeBody
• add unit test

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR doesn't introduce circular dependencies
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[tdonohue]

@bruno-atmire : If you could rebase this on the latest main, the CI/build process has just been fixed. Once you pull in the fix, your tests should hopefully succeed.

[tdonohue]

👍 Looks correct and the reasoning makes sense & tests prove this is working as expected. The old code is obviously incorrect. Thanks @bruno-atmire !