Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin sidebar link a11y issues #1230

Merged

Conversation

YanaDePauw
Copy link
Contributor

References

Fixes #1170

Description

This PR ensures that users can tab through the sidebar menu using the keyboard.
Currently the expandable menus are still separated into two parts where the first is the icon, and the second is the link itself.
Tabbing through the menu will only pass over the icons. The text next to icon will be ignored to avoid tabbing to the same link twice.

The issue of separation of the icon and text will be addressed as part of #1185.

Instructions for Reviewers

  • Log in as an administrator
  • Verify that you can tab over all the entries in the side bar menu
  • Verify that pressing enter on a collapsed menu will open it and that you can navigate through the submenu using tab

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@artlowel artlowel added 1 APPROVAL pull request only requires a single approval to merge accessibility bug component: administrative tools Related to the admin menu or tools e/2 Estimate in hours high priority labels Jun 14, 2021
@artlowel artlowel added this to the 7.0 milestone Jun 14, 2021
@tdonohue tdonohue self-requested a review June 17, 2021 14:48
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @YanaDePauw , this looks correct to me, and looks to solve the admin sidebar issues as described by Deque.

@tdonohue tdonohue merged commit cfd6512 into DSpace:main Jun 17, 2021
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Jan 23, 2024
[DSC-1108] added unit tests on collection/community page

Approved-by: Stefano Maffei
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge accessibility bug component: administrative tools Related to the admin menu or tools e/2 Estimate in hours high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deque Analysis] Action/Admin Sidebar is not entirely keyboard accessible
3 participants