Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header Accessibility Fix: Allow enter key or spacebar to expand or contract menu based on current active status #1315

Merged
merged 7 commits into from
Oct 4, 2021
Merged

Header Accessibility Fix: Allow enter key or spacebar to expand or contract menu based on current active status #1315

merged 7 commits into from
Oct 4, 2021

Commits on Sep 14, 2021

  1. Allow enter key to expand or contract menu based on current active st… 

    …atus
    @tdonohue
    tdonohue committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    b86ae8d View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Fix existing tests. Add new specs for enter key presses

    @tdonohue
    tdonohue committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    8e2ab83 View commit details
    Browse the repository at this point in the history

  2. Minor updates to README to provide more helpful info on unit tests

    @tdonohue
    tdonohue committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    523fca2 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Also support using spacebar to open/close menu

    @tdonohue
    tdonohue committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    e5e6e9c View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Attempt to stop scroll to bottom of page when clicking spacebar

    @tdonohue
    tdonohue committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    7747a8c View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Switch from keyup to keydown to fix spacebar scrolling issue.

    @tdonohue
    tdonohue committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    1d0a5c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Move actions to keyup while having preventDefault on keydown

    @tdonohue
    tdonohue committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    b4732f3 View commit details
    Browse the repository at this point in the history