[CST-4767] Password are not properly url encoded at login

[davide-negretti]

References

• Fixes Password are not properly url encoded at login #1367

Description

When submitting login form only a few special characters were manually URL encoded. Now all special characters are automatically encoded with encodeURIComponent().

Instructions for Reviewers

Login should now be possible when username and password contain special characters like #%+!
List of changes in this PR:

• encode-decode.util.ts has been fixed

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR doesn't introduce circular dependencies
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[tdonohue]

@artlowel : Added you as a secondary reviewer...it might only need a very quick glance from you. I'll give it a test myself though.

[tdonohue]

👍 Verified the bug on demo7.dspace.org with the "test@example.com" account as described in #1367. Also verified that this PR fixes that bug, and login works as expected even when a username or password includes special characters. Thanks @davidenegretti-4science !

[artlowel]

Thanks @davidenegretti-4science!

It works, but why not simply get rid of the loginEncodeUrl method and the encode-decode.util.ts file, and use encodeURIComponent directly?

[davide-negretti]

Thanks @davidenegretti-4science!

It works, but why not simply get rid of the loginEncodeUrl method and the encode-decode.util.ts file, and use encodeURIComponent directly?

The method was kept in order to mantain test coverage. Now I have removed it and tested again

[artlowel]

Thanks!