Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feed from search results (Angular) #3227

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ConfusionOrb221
Copy link

@ConfusionOrb221 ConfusionOrb221 commented Jul 31, 2024

References

Description

Adjusts RSS to show on search pages as well as include page, discovery configuration, and search filter information.

Instructions for Reviewers

RssComponent now looks at the discovery configruation of the search page it is attached to and then provides the information to the openSearch endpoint. This has also been updated to including the following information:

  • Page
  • FixedFilter (for browse by pages)
  • SearchFilters
  • Sort

To test this pr you have to use the provided rest branch and then verify that rss button on search pages has results that match search queries no matter the filters or actual query provided.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@ConfusionOrb221 ConfusionOrb221 marked this pull request as ready for review August 5, 2024 17:36
@tdonohue tdonohue added component: Discovery related to discovery search or browse system new feature integration: syndication feed Related to RSS / ATOM syndication feeds labels Aug 5, 2024
@tdonohue tdonohue changed the title Rss on search pages RSS feed from search results (Angular) Aug 5, 2024
Copy link

github-actions bot commented Nov 1, 2024

Hi @ConfusionOrb221,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Discovery related to discovery search or browse system integration: syndication feed Related to RSS / ATOM syndication feeds new feature
Projects
Status: 👀 Under Review
Development

Successfully merging this pull request may close these issues.

RSS feed from search results on DSpace
3 participants