Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker files for 8_x #3681

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Update docker files for 8_x #3681

merged 1 commit into from
Nov 21, 2024

Conversation

dheles
Copy link

@dheles dheles commented Nov 21, 2024

Description

Fixes reference to latest in docker files (since 8_x is no longer latest)

Instructions for Reviewers

Follow the instructions here:
https://wiki.lyrasis.org/display/DSPACE/Testing+DSpace+Github+Pull+Requests
to stand up a copy of the DSpace backend using docker. Check to make sure it's using the latest 8_x version.

List of changes in this PR:

  • updated docker files to match their 7_x counterparts

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker labels Nov 21, 2024
@tdonohue tdonohue added this to the 8.1 milestone Nov 21, 2024
@tdonohue tdonohue self-requested a review November 21, 2024 19:32
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @dheles for catching this. This all looks correct, and the tests pass (which means it's working / building fine)

@tdonohue tdonohue merged commit 3a18805 into DSpace:dspace-8_x Nov 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker
Projects
Development

Successfully merging this pull request may close these issues.

2 participants