Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SSR and SSG #101

Merged
merged 5 commits into from
Jan 21, 2022
Merged

Added SSR and SSG #101

merged 5 commits into from
Jan 21, 2022

Conversation

KhalidAdan
Copy link
Contributor

@KhalidAdan KhalidAdan commented Jan 18, 2022

Adds serverside rendering and static site generation to the app! Pretty straightforward except for the eligibility smoke test being broken by a lack of props (Next passes serverside rendered data in as a prop). Ended up solving it by doing what getServersideProps does and passed that response body in.

@vercel
Copy link

vercel bot commented Jan 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

eligibility-estimator – ./

🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/BtxqQxznfi4E2rRcbm5Hmp8RMPvD
✅ Preview: https://eligibility-estimator-git-feature-ssr-ssg-eligibility-estimator.vercel.app

Copy link
Contributor

@JeremyKennedy JeremyKennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some teeny questions, but overall I am liking the effects of this PR! Cool stuff!

__tests__/pages/eligibility.test.tsx Outdated Show resolved Hide resolved
pages/eligibility/index.tsx Outdated Show resolved Hide resolved
@KhalidAdan KhalidAdan merged commit 626cab6 into develop Jan 21, 2022
@KhalidAdan KhalidAdan deleted the feature/SSR-SSG branch January 21, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants