-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SSR and SSG #101
Added SSR and SSG #101
Conversation
This pull request is being automatically deployed with Vercel (learn more). eligibility-estimator – ./🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/BtxqQxznfi4E2rRcbm5Hmp8RMPvD |
8cce36c
to
d603517
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some teeny questions, but overall I am liking the effects of this PR! Cool stuff!
Adds serverside rendering and static site generation to the app! Pretty straightforward except for the eligibility smoke test being broken by a lack of props (Next passes serverside rendered data in as a prop). Ended up solving it by doing what
getServersideProps
does and passed that response body in.