Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

175541 - Remove Countries #1031

Merged
merged 1 commit into from
Mar 25, 2024
Merged

175541 - Remove Countries #1031

merged 1 commit into from
Mar 25, 2024

Conversation

MarcoGoC
Copy link
Contributor

@MarcoGoC MarcoGoC commented Mar 15, 2024 •
edited by azure-boards bot
Loading

AB#175541 - remove countries for error message

Description

  • removed and adjusted tests for countries errors

List of proposed changes:

  • added Outside of Canada to list of countries used for the validation

What to test for/How to test

  • on staging enter chose Outside of Canada to get the error. then run this branch to not get the error

Additional Notes

@MarcoGoC MarcoGoC requested a review from a team March 15, 2024 19:47
@github-actions GitHub Actions
Copy link

Dynamic branch URL: https://app-eligibilityestimator-dev-pr-preview-1031.azurewebsites.net

alex-solo
alex-solo approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@alex-solo alex-solo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the coutries were already removed in a previous PR recently? Looks like they're back but being commented out. Is there a reason for that?

@MarcoGoC MarcoGoC merged commit d3f6bb0 into develop Mar 25, 2024
4 checks passed
@MarcoGoC MarcoGoC deleted the 175541-removeCountries branch March 25, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-solo alex-solo alex-solo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGoC @alex-solo