Improve unexpected field handling #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). eligibility-estimator – ./🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/BkpVbNa9cUnAHLvPmqG8L1zDnHxx |
KhalidAdan
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my end, I changed my logic so that in all cases I'm aware of, things are handled as expected even when unexpected fields are sent to the API. Specifically, when partner income is sent while marital status is single, things are still good.
Also removed the forbidden field rules, so when formerly forbidden fields are sent, there is no longer any errors.