Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/front end tests #108

Merged
merged 7 commits into from
Jan 25, 2022
Merged

Feature/front end tests #108

merged 7 commits into from
Jan 25, 2022

Conversation

KhalidAdan
Copy link
Contributor

@KhalidAdan KhalidAdan commented Jan 20, 2022

This is the first pass at getting better front-end code coverage, it's getting a little large so I think I'll get this half reviewed and then setup the next set of tests in a separate PR.

@vercel
Copy link

vercel bot commented Jan 20, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

eligibility-estimator – ./

🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/5n3iDJ9D3JmDEAVPLRVnyRJ8gKFk
✅ Preview: https://eligibility-estimator-git-feature-0f7fd2-eligibility-estimator.vercel.app

.gitignore Show resolved Hide resolved
@KhalidAdan
Copy link
Contributor Author

KhalidAdan commented Jan 24, 2022

There seems to be an issue where toString().replaceAll(x,y) doesn't exist in the test environment but works fine locally -- trying to fix this now!

Edit: Our version of node on this project does not have replaceAll(), gonna try and use a shim in test

Edit x2: That did it!

Copy link
Contributor

@JeremyKennedy JeremyKennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me!

@KhalidAdan KhalidAdan merged commit be9c738 into develop Jan 25, 2022
@KhalidAdan KhalidAdan deleted the feature/front-end-tests branch January 25, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants