Rework frontend tooltip definition implementation #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). eligibility-estimator – ./🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/13UQPTnXh8z8GRgJ7gEAoUNt34dF |
KhalidAdan
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty of rewriting the tooltip handling to use a similar translation approach as the backend, as well as adding support to reference other tooltip text values. The latter is not visible in this PR, but will be used by the New Partner Questions PR #111. You can actually check the deployment for that PR to see how this PR affects that one.
It seems to work as expected, I don't think I broke anything. Obviously, as proper language support isn't in the frontend, I default to English, and the French file is still all just English.