Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed change to form layout #121

Merged
merged 6 commits into from
Jan 27, 2022
Merged

Conversation

KhalidAdan
Copy link
Contributor

@KhalidAdan KhalidAdan commented Jan 27, 2022

Proposing making the below that would make all question types the same width and prevent overlapping of the needhelp component while scrolling. A one liner!

Before (as in mockups):

before.mp4

After:

after.mp4

@vercel
Copy link

vercel bot commented Jan 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

eligibility-estimator – ./

🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/DoukggK5Dbk2GzXgWDhREDT3amXB
✅ Preview: https://eligibility-estimator-git-preview-5f5cc8-eligibility-estimator.vercel.app

@KhalidAdan KhalidAdan changed the title Preview/two column layout Proposed change to form layout Jan 27, 2022
@KhalidAdan
Copy link
Contributor Author

KhalidAdan commented Jan 27, 2022

WIP -- need to rebase develop and fix conflicts, just need the go ahead from the team

Edit: Spoke with Alla and she is not a fan of the change, this might sit until our Monday meeting where we can talk as a team

Edit 2: This is needed to fix a bug for demos, so it need's to go out. If we end up removing things, we can do so in a followup PR!

@JeremyKennedy JeremyKennedy marked this pull request as draft January 27, 2022 18:31
Copy link
Contributor

@JeremyKennedy JeremyKennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to Wiam, Joan, and myself, lol. Approved!

@KhalidAdan KhalidAdan merged commit 226a1e7 into develop Jan 27, 2022
@KhalidAdan KhalidAdan deleted the preview/two-column-layout branch January 27, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants