-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed change to form layout #121
Conversation
This pull request is being automatically deployed with Vercel (learn more). eligibility-estimator – ./🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/DoukggK5Dbk2GzXgWDhREDT3amXB |
WIP -- need to rebase develop and fix conflicts, just need the go ahead from the team Edit: Spoke with Alla and she is not a fan of the change, this might sit until our Monday meeting where we can talk as a team Edit 2: This is needed to fix a bug for demos, so it need's to go out. If we end up removing things, we can do so in a followup PR! |
d15efab
to
3e6d1ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to Wiam, Joan, and myself, lol. Approved!
Proposing making the below that would make all question types the same width and prevent overlapping of the needhelp component while scrolling. A one liner!
Before (as in mockups):
before.mp4
After:
after.mp4