Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Adobe Analytics #182

Merged
merged 8 commits into from
Feb 28, 2022
Merged

Addition of Adobe Analytics #182

merged 8 commits into from
Feb 28, 2022

Conversation

KhalidAdan
Copy link
Contributor

@KhalidAdan KhalidAdan commented Feb 23, 2022

Added AA to the home page, and the push function is being called, but blocked on the AA site / checking functionality. How do we confirm the analytics is working? There seems to be one sample project with 11500 projects.

@vercel
Copy link

vercel bot commented Feb 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

eligibility-estimator – ./

🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/7YMNE4RnEHnLApvaMQDUgqkY5ai3
✅ Preview: https://eligibility-estimator-git-feature-e5cf56-eligibility-estimator.vercel.app

@KhalidAdan KhalidAdan changed the title first pass at AA impl, scripts confirmed inserted and sending requests AA on home page, push being sent Feb 23, 2022
@KhalidAdan KhalidAdan force-pushed the feature/adobe-analytics branch from bb610ce to d0f22b3 Compare February 23, 2022 18:18
client-state/store.ts Outdated Show resolved Hide resolved
@KhalidAdan
Copy link
Contributor Author

image

@KhalidAdan KhalidAdan force-pushed the feature/adobe-analytics branch from 5f44ea8 to 6243d1b Compare February 28, 2022 17:22
Copy link
Contributor

@JeremyKennedy JeremyKennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough! Some duplicated code but it sounds like you want this out ASAP so I'll approve.

components/Tabs/index.tsx Show resolved Hide resolved
pages/eligibility/index.tsx Show resolved Hide resolved
pages/index.tsx Show resolved Hide resolved
@KhalidAdan
Copy link
Contributor Author

I'll make a note of the objections and swing back around to fix, ty for the speedy review!

@KhalidAdan KhalidAdan merged commit e82a12f into develop Feb 28, 2022
@KhalidAdan KhalidAdan deleted the feature/adobe-analytics branch February 28, 2022 20:54
JeremyKennedy added a commit that referenced this pull request Feb 28, 2022
Addition of Adobe Analytics (#182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants