generated from DTS-STN/next-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new radio button question for OAS Deferral #300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JeremyKennedy
changed the title
wip: always show deferral
Add new radio button question for OAS Deferral
Jun 14, 2022
JeremyKennedy
force-pushed
the
feature/always_show_deferral
branch
from
June 15, 2022 18:07
3ec2129
to
f441489
Compare
alex-solo
approved these changes
Jun 15, 2022
JeremyKennedy
force-pushed
the
feature/always_show_deferral
branch
from
June 16, 2022 23:21
d4907ef
to
2206dc4
Compare
JeremyKennedy
force-pushed
the
feature/always_show_deferral
branch
from
June 16, 2022 23:29
2206dc4
to
80dc170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we would display the
oasAge
question when age is 65-70. This was kinda jarring, having the question pop-up unexpectedly. This PR adds a new radio button question asking the user if they want to defer. If they do, theoasAge
question will show up. Yes, this is a "pop-up" but it's more expected and immediate.todo:
[OAS Deferral]
a proper link