support when income is not known #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JeremyKennedy
changed the title
JeremyKennedy
force-pushed
the
feature/income_unknown
branch
from
8adb837 to
c67d3eb
Compare
JeremyKennedy
force-pushed
the
feature/income_unknown
branch
from
c67d3eb to
0575ff8
Compare
JeremyKennedy
force-pushed
the
feature/income_unknown
branch
from
0575ff8 to
7fa8514
Compare
JeremyKennedy
force-pushed
the
feature/income_unknown
branch
from
7fa8514 to
d6307e8
Compare
…"you and your partner's income"
… raised as the user is typing, unlike age)
JeremyKennedy
changed the title
alex-solo
approved these changes
Jun 21, 2022
MarcoGoC
reviewed
Jun 21, 2022
MarcoGoC
approved these changes
Jun 21, 2022
# Conflicts: # __tests__/pages/api/benefits.test.ts # __tests__/pages/api/help-me-find-out.test.ts # utils/api/benefits/afsBenefit.ts # utils/api/benefits/alwBenefit.ts # utils/api/benefits/oasBenefit.ts # utils/api/definitions/textReplacementRules.ts # utils/api/summaryHandler.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly adds support for when income is not known. This is done by first asking the user if they want to provide their income, and if they do, then we show the income question. Same for partner income. If either income is not provided, that will affect the results available.
I have differed from the mockups somewhat in order to accommodate the existing application structure. Rather than having a checkbox and an optional field, I've gone with radio buttons which will show the income field if Yes is selected (exactly as we have the OAS Deferral). This keeps consistency with the rest of the app, and keeps complexity to a minimum, since we're using logic our app supports already.
The results page is still using the old layout, as the new one is not complete yet.
Several things were improved as a result of this PR:
If interested, you can check out some screenshots I've added to JIRA here: https://jira-dev.bdm-dev.dts-stn.com/browse/SAEB-1310