Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing an underscore #971

Merged
merged 1 commit into from
Dec 12, 2023
Merged

removing an underscore #971

merged 1 commit into from
Dec 12, 2023

Conversation

andr0272
Copy link
Contributor

No description provided.

Copy link

Copy link
Collaborator

@alex-solo alex-solo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@andr0272 andr0272 merged commit 06d1125 into develop Dec 12, 2023
7 checks passed
@andr0272 andr0272 deleted the pipelineUnderscore branch December 12, 2023 22:09
andr0272 added a commit that referenced this pull request Dec 20, 2023
* collaps result summary in mobile

* title language fix

* changed date to 1900 to match error message

* Checking in tests

* force white background on select

* check benefit exists

* just to check deployment

* update title

* final test fixes.

* update

* change reference to ALWS

* change year to 1899

* initial commit

* Update build-and-push-dev.yml

* Update build-and-push-prod.yml

* Update build-and-push-dev.yml

* Update build-and-push-prod.yml

* fixing trigger and cleanup

* fix:updated rates for Q1 2024

* updated links and border color on focus

* fix:updated rates for Q1 2024

* fix: removed excess packages

* Adding pipeline secrets

* Use fieldDefinition instead of categoryMapping

* Adding values for variables, removing unused secrets

* ADO 134595: Refactor benefitHandler (#960)

* Undoing previous commit, cleaning up the variable names

* Using a new service principal

* July 2013 OAS deferral (#945)

Co-authored-by: VeroBr0~ <veronique.breault@cgi.com>
Co-authored-by: Veronique B <131703940+VeroBr0@users.noreply.github.com>

* updated link anchor for footer

* update width

* update

* Adding the NEXT_AUTH_SECRET variable

* Adding the EXPOSE instruction for the proper port of this app

* Revert "Q124 rate update"

* removing an underscore (#971)

* Pipeline underscore (#972)

* removing an underscore

* testing new home var

* Pipeline underscore2 (#974)

testing new home var

* Fix 143948

* fix for failing tests

* Pipeline updates (#977)

* Updating pipelines

* Updating pipelines

* Pipeline underscore (#973)

* removing an underscore

* testing new home var

* testing new home var

* clarify comment

* Pipeline updates (#978)

* Updating pipelines

* Updating pipelines

* Fixing a docker tag problem

---------

Co-authored-by: Jeremy Kennedy <jerekennedy@deloitte.ca>
Co-authored-by: Marco <52539578+MarcoGoC@users.noreply.github.com>

* added condition for partner legal status

* updated dev yml

* hotfix typo

* Remove leading space in message, fix for 40 years not displaying

* added params to current result benefit handler

* super hotfix

* Merge main (#989)

* Updating pipelines

* Fixing pipeline files

* merge main

---------

Co-authored-by: shawn320 <azuneko1110@gmail.com>
Co-authored-by: MarcoGoC <marcogoc951@gmail.com>
Co-authored-by: Maxim Lam <maxim.lam@hrsdc-rhdcc.gc.ca>
Co-authored-by: Marco <52539578+MarcoGoC@users.noreply.github.com>
Co-authored-by: Adam <adam.andrews2797@gmail.com>
Co-authored-by: Maxim Lam <109530511+Maxim-Lam@users.noreply.github.com>
Co-authored-by: Adam Andrews <35509135+andr0272@users.noreply.github.com>
Co-authored-by: “Patrick“ <p@rickjobin.com>
Co-authored-by: VeroBr0~ <veronique.breault@cgi.com>
Co-authored-by: Veronique B <131703940+VeroBr0@users.noreply.github.com>
Co-authored-by: Jeremy Kennedy <jerekennedy@deloitte.ca>
alex-solo added a commit that referenced this pull request Dec 27, 2023
* collaps result summary in mobile

* title language fix

* changed date to 1900 to match error message

* Checking in tests

* force white background on select

* check benefit exists

* just to check deployment

* update title

* final test fixes.

* update

* change reference to ALWS

* change year to 1899

* initial commit

* Update build-and-push-dev.yml

* Update build-and-push-prod.yml

* Update build-and-push-dev.yml

* Update build-and-push-prod.yml

* fixing trigger and cleanup

* fix:updated rates for Q1 2024

* updated links and border color on focus

* fix:updated rates for Q1 2024

* fix: removed excess packages

* Adding pipeline secrets

* Use fieldDefinition instead of categoryMapping

* Adding values for variables, removing unused secrets

* ADO 134595: Refactor benefitHandler (#960)

* Undoing previous commit, cleaning up the variable names

* Using a new service principal

* July 2013 OAS deferral (#945)

Co-authored-by: VeroBr0~ <veronique.breault@cgi.com>
Co-authored-by: Veronique B <131703940+VeroBr0@users.noreply.github.com>

* updated link anchor for footer

* update width

* update

* Adding the NEXT_AUTH_SECRET variable

* Adding the EXPOSE instruction for the proper port of this app

* Revert "Q124 rate update"

* removing an underscore (#971)

* Pipeline underscore (#972)

* removing an underscore

* testing new home var

* Pipeline underscore2 (#974)

testing new home var

* Fix 143948

* fix for failing tests

* Pipeline updates (#977)

* Updating pipelines

* Updating pipelines

* Pipeline underscore (#973)

* removing an underscore

* testing new home var

* testing new home var

* clarify comment

* Pipeline updates (#978)

* Updating pipelines

* Updating pipelines

* Fixing a docker tag problem

---------

Co-authored-by: Jeremy Kennedy <jerekennedy@deloitte.ca>
Co-authored-by: Marco <52539578+MarcoGoC@users.noreply.github.com>

* added condition for partner legal status

* updated dev yml

* hotfix typo

* fix:ran scraper

* fix:ran scraper

* Remove leading space in message, fix for 40 years not displaying

* added params to current result benefit handler

* super hotfix

* Merge main (#989)

* Updating pipelines

* Fixing pipeline files

* merge main

---------

Co-authored-by: shawn320 <azuneko1110@gmail.com>
Co-authored-by: MarcoGoC <marcogoc951@gmail.com>
Co-authored-by: Maxim Lam <maxim.lam@hrsdc-rhdcc.gc.ca>
Co-authored-by: Marco <52539578+MarcoGoC@users.noreply.github.com>
Co-authored-by: Adam <adam.andrews2797@gmail.com>
Co-authored-by: Maxim Lam <109530511+Maxim-Lam@users.noreply.github.com>
Co-authored-by: Adam Andrews <35509135+andr0272@users.noreply.github.com>
Co-authored-by: “Patrick“ <p@rickjobin.com>
Co-authored-by: VeroBr0~ <veronique.breault@cgi.com>
Co-authored-by: Veronique B <131703940+VeroBr0@users.noreply.github.com>
Co-authored-by: Jeremy Kennedy <jerekennedy@deloitte.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants