144220 Income questions updates #991
Conversation
|
Dynamic branch URL: https://ep-be-dyna-question-update.bdm-dev-rhp.dts-stn.com |
There was a problem hiding this comment.
The calculations themselves seem to be working according to the new logic, nice! The tests are failing because both new fields are required as per Joi schema but the tests suite does not provide those values in any of the scenarios.
You can probably address this by setting it to zero if 'undefined' when the test suite excel sheet is being ingested. OR, since we'll need different new scenarios in the test suite, we'll need a new column for this new input. All the current tests can be auto-filled to zero or "N/A" as long as the test scripts know how to read the sheet, it's all fair game.
Take a look at excelReaderUtil.ts to see how the sheet is being processed currently. Let me know if you have any more questions!
|
Dynamic branch URL: https://ep-be-dyna-question-update.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-question-update.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-question-update.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-question-update.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-question-update.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-question-update.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-question-update.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-question-update.bdm-dev-rhp.dts-stn.com |
144220 - Income questions updates
Description
Added a new field for salary exemption under Income category.
Calculation updates:
To calculate income for GIS, ALW and ALWS, take the input from the first field and SUBTRACT these amounts from the second field:
the first $5,000
50% of next $10,000
The maximum subtraction possible is $10,000 if input is $15,000 or more.
To calculate income for partner GIS, ALW and ALWS, apply the same calculation to the inputs.
To compare against recovery threshold for OAS pension, use income from first field only (no subtractions).
Updated error handling: Second income field cannot be greater than net income, also apply to partner income.
Updated income question: The income question, hint expand text, and error message should change dynamically based on user's input on the receiveOAS field. More detail on Figma