Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to error field when submitting faulty form #993

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Maxim-Lam
Copy link
Contributor

@Maxim-Lam Maxim-Lam commented Jan 8, 2024

AB#129196 - Jump to error field

Description

  • When trying to submit a faulty form, bring user to the error field

List of proposed changes:

  • added id to error field
  • jump to the error field if form is not valid

What to test for/How to test

  • fill out form, change a field to have an error, click estimate my benefit.
  • it should bring you back to the error field

Additional Notes

Copy link

github-actions bot commented Jan 8, 2024

Copy link
Collaborator

@alex-solo alex-solo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done. If the requirement was to bring the focus to the summary of errors and not the first occurrence of error. Also, as a user, would prefer a gentle scroll up instead of snapping into focus but if it's all good with Andreanne, then great!

@Maxim-Lam Maxim-Lam merged commit f5e5c28 into develop Jan 8, 2024
4 checks passed
@Maxim-Lam Maxim-Lam deleted the 129196-add-jump-to-error-field branch January 8, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants