Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72246 implement graphql client #29

Merged
merged 6 commits into from
Sep 22, 2022
Merged

Conversation

DaceyTom2
Copy link
Contributor

DTSCI-72246 (Jira Issue)

Description

GraphQL client boilerplate code added to SCH

List of proposed changes:

  • Added AEM env variable
  • Added GraphQL client
  • Updated dockerfile to add env

What to test for/How to test

Currently unimplemented in the code

Additional Notes

Teamcity will need to be updated to include the env. It currently exists in vault

@DaceyTom2 DaceyTom2 requested a review from a team as a code owner September 16, 2022 12:21
Dockerfile Show resolved Hide resolved
graphql/client.js Show resolved Hide resolved
@nibivi77 nibivi77 self-requested a review September 16, 2022 13:22
Copy link
Contributor

@nibivi77 nibivi77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved before seeing Shaun's comments. Good points were raised with both comments.

Copy link
Member

@s-laugh s-laugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, catching, fail hard flow will resolve once implemented.

@DaceyTom2 DaceyTom2 merged commit 200f9ca into dev Sep 22, 2022
@DaceyTom2 DaceyTom2 deleted the 72246-implement-graphql-client branch September 22, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants