Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some additional repo configurations #3

Merged
merged 5 commits into from
Sep 8, 2022
Merged

Some additional repo configurations #3

merged 5 commits into from
Sep 8, 2022

Conversation

s-laugh
Copy link
Member

@s-laugh s-laugh commented Sep 1, 2022

Description

List of proposed changes:

  • Updates to README
  • Updates to Helm project name

What to test for/How to test

Additional Notes

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Integration Deployment 🚀 - Check build status
Jest Coverage Report GitHub Workflow Status
Cypress Coverage Report GitHub Workflow Status

@s-laugh s-laugh requested a review from a team September 8, 2022 12:09
DaceyTom2
DaceyTom2 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@DaceyTom2 DaceyTom2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For next time I'd recommend breaking up changes into smaller PRs.
It makes them easier to review, track history and clearer intention. While being less error prone

@s-laugh s-laugh merged commit 87d6cd0 into main Sep 8, 2022
@s-laugh s-laugh deleted the repo-setup branch September 8, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaceyTom2 DaceyTom2 DaceyTom2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-laugh @DaceyTom2