Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating Security page. #64

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Creating Security page. #64

merged 3 commits into from
Oct 14, 2022

Conversation

nibivi77
Copy link
Contributor

ADO-81782

Description

Creating Security page.

Test

  • Navigate from French and English to and from home and security page.

Additional Notes

  • Tests will come later.

@nibivi77 nibivi77 marked this pull request as ready for review October 13, 2022 16:06
@nibivi77 nibivi77 requested a review from a team as a code owner October 13, 2022 16:06
@github-actions
Copy link

Integration Deployment 🚀 - Build Status)
Default Tests Workflow Status
Jest Coverage Report
Cypress Coverage Report

shewood
shewood reviewed Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@shewood shewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Will you be updating the breadcrumbs in this PR or another?

CurtisUnderwood
CurtisUnderwood approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@CurtisUnderwood CurtisUnderwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Made changes to Layout in my PR to allow for custom breadcrumbs check that out so there's no conflict

@nibivi77 nibivi77 requested a review from shewood October 14, 2022 14:57
@nibivi77 nibivi77 merged commit 104b4be into dev Oct 14, 2022
@nibivi77 nibivi77 deleted the security-page branch October 14, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CurtisUnderwood CurtisUnderwood CurtisUnderwood approved these changes

@shewood shewood Awaiting requested review from shewood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nibivi77 @shewood @CurtisUnderwood