fix: improve active style and prevent the show of native contextMenu (#…

…225) * fix: prevent the show of native contextMenu in tab * fix: improve the active style of acitivity bar
DTStack · Jul 7, 2021 · 70f3804 · 70f3804
1 parent 9f25dd5
commit 70f3804
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/components/tabs/tab.tsx b/src/components/tabs/tab.tsx
@@ -61,6 +61,7 @@ export function Tab<T>(props: ITabProps) {
     const handleMouseOut = () => setHover(false);
     const handleOnContextMenu = useCallback(
         (event: React.MouseEvent) => {
+            event.preventDefault();
             onContextMenu?.(event, props);
         },
         [props]

diff --git a/src/style/theme/activitybar.scss b/src/style/theme/activitybar.scss
@@ -10,22 +10,18 @@
         background: var(--activityBar-activeBorder);
     }
 
-    &__item--checked {
-        #{$activityBar}__label {
-            background-color: var(--activityBar-activeBackground);
-            border-color: var(--activityBar-activeFocusBorder);
-            color: var(--activityBar-activeBorder);
-        }
-    }
-
     &__item {
         color: var(--activityBar-inactiveForeground);
 
         &:hover,
-        &__label .codicon {
+        &__label {
             background-color: var(--activityBar-activeBackground);
             border-color: var(--activityBar-activeBorder);
             color: var(--activityBar-activeBorder);
         }
     }
+
+    &__item--checked {
+        color: var(--activityBar-activeBorder);
+    }
 }