refactor: optimize the MoleculeProvider #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 85.58% 86.50% +0.91%
==========================================
Files 182 188 +6
Lines 5307 5476 +169
Branches 1189 1213 +24
==========================================
+ Hits 4542 4737 +195
+ Misses 758 729 -29
- Partials 7 10 +3
Continue to review full report at Codecov.
|
wewoor
changed the title
mortalYoung
requested changes
Nov 23, 2021
mortalYoung
requested changes
Nov 29, 2021
wewoor
force-pushed
the
fix/moleculeProvider
branch
from
923832d to
21939fe
Compare
wewoor
added a commit
that referenced
this pull request
Dec 1, 2021
* refactor: update the MoleculeProvider * fix(molecule provider): init workbench ui after init locales * test: unit test for splitLanguagesExts * docs: comments for MoleculeProvider * test: unit test for MoleculeProvider * refactor(i18n): update the apis of locales * fix: correct the reset to rest * chore: ignore website prettier * style: prettify code * test: update the snapshot case * test: remove the snapshot * test: update snapshot * ci: yarn test -u * ci: remove the -u argument of yarn test * test: update the MoleculeProvider snap
wewoor
added a commit
that referenced
this pull request
Dec 6, 2021
* docs: update the introduction * docs: update the Introduction of zhCN version * docs: tutorials for keybinding, quickAccess and Icon * feat: improve homepage (#527) * build: update the limitation of node version (#515) * fix: fix can't clear the notifications (#518) * fix: fix can't clear the notifications * test: update tests * test: ignore render tests * fix: fix create file node incorrect on contextMenu (#522) * refactor: optimize the MoleculeProvider (#517) * refactor: update the MoleculeProvider * fix(molecule provider): init workbench ui after init locales * test: unit test for splitLanguagesExts * docs: comments for MoleculeProvider * test: unit test for MoleculeProvider * refactor(i18n): update the apis of locales * fix: correct the reset to rest * chore: ignore website prettier * style: prettify code * test: update the snapshot case * test: remove the snapshot * test: update snapshot * ci: yarn test -u * ci: remove the -u argument of yarn test * test: update the MoleculeProvider snap * fix: show the SubMenu in right place when the Menu is horizontal mode (#526) * fix: show the submenu in right place when horizontal mode * test: update the snap of Menu * feat: support sort in folderTree (#524) * feat: support sort in folderTree * feat: improve check hidden files * docs: update Guides * docs: unify the files name * docs: update Guides, Overview * docs: update the QuickStart * docs: update the first extension * docs: update the extension guides * docs: update Workbench UI * fix: improve the circular dep error when execute yarn link (#528) * fix: remove the warning in console (#529) * fix: remove the warning in console * test: update snapshots * docs: update ColorTheme, readme, keybinding, i18n * docs: update Keybinding * docs: update quickAccess, add demo tips * docs: update i18n * docs: update Settings guide * docs: update Icon guide * docs: update customize the Workbench guide * docs: update images * docs: update Contributing * docs: update English version * fix: remove the 140 width limit for buttons * docs: default locale is zh-CN * docs: improve the links (#533) Co-authored-by: 野迂迂 <yangwei1@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactor the loading logic of Extensions in MoleculeProvider.
Changes
colorThemeprops from MoleculeProvidercontainerproperty getter of MoleculeProviderinitControllerstoinitWorkbenchUIsplitLanguagesExtsmethod intoExtensionServiceinitializelogic to:initWorkspace->initLocaleExts->initWorkbenchUI->load(defaultExtensions)->load(resetExts)