Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve usage examples in TestPane #669

Merged
merged 2 commits into from
Feb 28, 2022
Merged

feat: Improve usage examples in TestPane #669

merged 2 commits into from
Feb 28, 2022

Conversation

kiwiwong
Copy link
Collaborator

@kiwiwong kiwiwong commented Feb 24, 2022

Description

Improve usage examples in TestPane.

Fixes #591

Changes

  • Improve the style of TestPane.
  • Improve the logic of some operations.
  • Improve some display names and content.
  • Add more usage examples.
  • Use Notification to show the results of operations that cannot see changes on the page directly.

@kiwiwong kiwiwong added enhancement New feature or request feature labels Feb 24, 2022
@kiwiwong kiwiwong self-assigned this Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #669 (395f6b1) into main (e9a8cdd) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   90.66%   90.67%   +0.01%     
==========================================
  Files         189      189              
  Lines        5926     5933       +7     
  Branches     1421     1425       +4     
==========================================
+ Hits         5373     5380       +7     
  Misses        546      546              
  Partials        7        7              
Impacted Files Coverage Δ
src/services/theme/helper.ts 100.00% <0.00%> (ø)
src/services/theme/colorRegistry.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a8cdd...395f6b1. Read the comment docs.

@kiwiwong kiwiwong removed the feature label Feb 24, 2022
@wewoor wewoor requested a review from SQLGate February 24, 2022 11:26
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor
Copy link
Collaborator

wewoor commented Feb 24, 2022

I think @SQLGate not only requires the TestPane need to improve, and also needs to provide more samples of Workbench?

@kiwiwong kiwiwong changed the title feat: improve usage examples in Workbench of Storybook WIP: feat: improve usage examples in Workbench of Storybook Feb 25, 2022
@wewoor
Copy link
Collaborator

wewoor commented Feb 25, 2022

@kiwiwong 这个 PR 我们修改为只针对 TestPane 的更新就好,针对 #591 我们单独 PR

@kiwiwong
Copy link
Collaborator Author

@kiwiwong 这个 PR 我们修改为只针对 TestPane 的更新就好,针对 #591 我们单独 PR

👌

@kiwiwong kiwiwong changed the title WIP: feat: improve usage examples in Workbench of Storybook feat: Improve usage examples in TestPane Feb 25, 2022
import { Scrollable } from 'mo/components';
import { randomId } from 'mo/common/utils';

function shortRandomId() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个跟 randomId 啥区别~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

randomId生成的id太长,页面上展示起来感觉不太好看

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 0d42c0f into main Feb 28, 2022
@wewoor wewoor deleted the feat/samples branch February 28, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Increase the readability of small samples in the Workbench of the Storybook
3 participants