Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): improve the styles in colorTheme Service #739

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复某些方法的返回值类型不正确的问题

Related Issues

Closed #738

@mortalYoung mortalYoung self-assigned this May 18, 2022
@mortalYoung mortalYoung added the bug Something isn't working label May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #739 (d49756c) into main (61b1753) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files         189      189           
  Lines        5947     5947           
  Branches     1426     1426           
=======================================
  Hits         5432     5432           
  Misses        508      508           
  Partials        7        7           
Impacted Files Coverage Δ
src/services/theme/colorThemeService.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b1753...d49756c. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 5d93078 into main May 19, 2022
@wewoor wewoor deleted the fix/theme branch May 19, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the return type of molecule.colorTheme.getThemeById is wrong
2 participants