Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support stop event emit #807

Merged
merged 4 commits into from
Oct 21, 2022
Merged

feat: support stop event emit #807

merged 4 commits into from
Oct 21, 2022

Conversation

mortalYoung
Copy link
Collaborator

简介

@mortalYoung mortalYoung self-assigned this Sep 21, 2022
@mortalYoung mortalYoung added the enhancement New feature or request label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 91.05% // Head: 91.06% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (df2633a) compared to base (219b937).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   91.05%   91.06%           
=======================================
  Files         180      180           
  Lines        5793     5797    +4     
  Branches     1404     1405    +1     
=======================================
+ Hits         5275     5279    +4     
  Misses        512      512           
  Partials        6        6           
Impacted Files Coverage Δ
src/common/event/eventEmitter.ts 100.00% <100.00%> (ø)
src/workbench/sidebar/explore/folderTree.tsx 97.70% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/common/event/eventEmitter.ts Outdated Show resolved Hide resolved
src/common/event/eventEmitter.ts Show resolved Hide resolved
@mortalYoung mortalYoung requested a review from wewoor October 20, 2022 11:44
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit f8451eb into main Oct 21, 2022
@wewoor wewoor deleted the feat/event branch October 21, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants