Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize modal confirm button style and fix redundacy heade… #810

Merged
merged 7 commits into from
Oct 21, 2022

Conversation

mumiao
Copy link
Collaborator

@mumiao mumiao commented Oct 18, 2022

#798

  • 启用了 cancelButtonProps: { disabled: true } 属性,cancel按钮会无法点击
  • 优化Modal组件以及 Modal.confirm 使用,Confirm Button的样式问题
  • 简化 Modal.confirm 展示,去除冗余的Header部分
  • 解决Modal.confirm 无法关闭的问题

@mumiao mumiao requested a review from mortalYoung October 18, 2022 11:54
@mumiao mumiao self-assigned this Oct 18, 2022
@mumiao mumiao changed the title refactor: optimize modal confirm button style and fix redundacy heade… 【WIP】refactor: optimize modal confirm button style and fix redundacy heade… Oct 18, 2022
@mumiao mumiao changed the title 【WIP】refactor: optimize modal confirm button style and fix redundacy heade… WIP refactor: optimize modal confirm button style and fix redundacy heade… Oct 18, 2022
@mumiao mumiao added bug Something isn't working enhancement New feature or request labels Oct 21, 2022
@mumiao mumiao changed the title WIP refactor: optimize modal confirm button style and fix redundacy heade… refactor: optimize modal confirm button style and fix redundacy heade… Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 91.05% // Head: 91.06% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b043b4f) compared to base (3b73285).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #810   +/-   ##
=======================================
  Coverage   91.05%   91.06%           
=======================================
  Files         180      180           
  Lines        5793     5795    +2     
  Branches     1404     1405    +1     
=======================================
+ Hits         5275     5277    +2     
  Misses        512      512           
  Partials        6        6           
Impacted Files Coverage Δ
src/components/dialog/actionButton.tsx 70.96% <71.42%> (ø)
src/components/dialog/confirm.tsx 92.85% <100.00%> (-0.48%) ⬇️
src/components/dialog/confirmDialog.tsx 95.45% <100.00%> (ø)
src/components/dialog/modal.tsx 96.15% <100.00%> (ø)
src/common/event/eventEmitter.ts 100.00% <0.00%> (ø)
src/services/workbench/panelService.ts 98.97% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mumiao mumiao mentioned this pull request Oct 21, 2022
12 tasks
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mortalYoung mortalYoung merged commit 4356e19 into main Oct 21, 2022
@mortalYoung mortalYoung deleted the fix/modal branch October 21, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants