Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix switch panels between problem and output #814

Merged
merged 2 commits into from
Oct 20, 2022
Merged

fix: fix switch panels between problem and output #814

merged 2 commits into from
Oct 20, 2022

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Oct 20, 2022

简介

  • 修复面板切换在某些情况下会报错导致无法切换的问题

主要变更

  • 出现问题的是地方是深拷贝的时候,需要跳过 StandaloneEditor 类。本来是通过 constructor.name 来判断,但是在 terser 之后会导致构造类的 name 发生改变,所以改成 instanceof 判断

Related Issues

Closed #812

@mortalYoung mortalYoung added the bug Something isn't working label Oct 20, 2022
@mortalYoung mortalYoung requested a review from wewoor October 20, 2022 03:55
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 91.05% // Head: 91.05% // No change to project coverage 👍

Coverage data is based on head (35514fc) compared to base (3b73285).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   91.05%   91.05%           
=======================================
  Files         180      180           
  Lines        5793     5793           
  Branches     1404     1404           
=======================================
  Hits         5275     5275           
  Misses        512      512           
  Partials        6        6           
Impacted Files Coverage Δ
src/services/workbench/panelService.ts 98.97% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mumiao mumiao merged commit ac9d577 into main Oct 20, 2022
@mumiao mumiao deleted the fix/panel branch October 20, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Problems 面板和 OutPut面板切换2-3次后无法切换,并且控制台报错
3 participants