Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove babel-loader for monaco-editor #821

Merged
merged 2 commits into from
Nov 11, 2022
Merged

build: remove babel-loader for monaco-editor #821

merged 2 commits into from
Nov 11, 2022

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Nov 2, 2022

简介

  • 移除 monaco-editor 的相关 rule
  • 适配 pnpm@7

主要变更

  • 限定 ts 的版本,并通过 .vscode 的配置,确保编辑器环境下的 ts 相关提示走的 ts 版本是项目里安装的而不是 vscode 所使用的

@mortalYoung mortalYoung added build dependencies Pull requests that update a dependency file labels Nov 2, 2022
@mortalYoung mortalYoung requested a review from wewoor November 2, 2022 07:12
@mortalYoung mortalYoung self-assigned this Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 91.06% // Head: 91.06% // No change to project coverage 👍

Coverage data is based on head (0dbe190) compared to base (d697d0b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #821   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files         180      180           
  Lines        5795     5795           
  Branches     1405     1405           
=======================================
  Hits         5277     5277           
  Misses        512      512           
  Partials        6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 0b71d12 into main Nov 11, 2022
@wewoor wewoor deleted the chore/webpack branch November 11, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants