Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use schema suggested by Giovanna and Alessandro #39

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

eflumerf
Copy link
Member

No description provided.

Copy link
Contributor

@glehmannmiotto glehmannmiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the feature. We may want to consider 1 further change and 1 addition:

  • add a boolean flag "execute_sequentially" (default set to false) in the ActionPlan class, such that, if for debugging reasons it is necessary to disable momentarily parallel executions, this can be done.
  • move the SmartDaqApplication from appmodel to confmodel, since it seems to me the only class that is left on app model which contributes to the global basic schema. (DaqApplication and DaqModules are already in confmodel)

@gcrone
Copy link
Contributor

gcrone commented Aug 30, 2024

* move the SmartDaqApplication from appmodel to confmodel, since it seems to me the only class that is left on app model which contributes to the global basic schema. (DaqApplication and DaqModules are already in confmodel)

Unfortunately this is not currently possible due the hack used to register generate_modules methods with the SmartDaqApplication. The SmartDaqApplication has to be in the same package as its derived classes.

…ution_policy attribute to ActionPlan that allows switching steps to serial execution (series of serial steps)
Copy link
Contributor

@glehmannmiotto glehmannmiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll update the configuration files according to the modifications in confmodel.

@eflumerf eflumerf merged commit 3672773 into develop Sep 3, 2024
1 check passed
@eflumerf eflumerf deleted the eflumerf/ActionPlans_DaqModulesGroup branch September 3, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants