Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GitHub CI scripts #395

Merged
merged 22 commits into from
Oct 18, 2024
Merged

Conversation

andrewmogan
Copy link
Collaborator

Addresses #392 and, incidentally, #383. Summary of the major changes:

Consolidated Workflows

  • Consolidate running, disabling, and syncing workflows into one script, run-workflow-action.sh
  • Combine disable-ci.sh and trigger-ci-workflow-all.sh into trigger-or-disable-ci-all.sh

Removals

  • Remove sync-ci-track-pr-workflow-to-template.sh because it didn't conform to the relatively new DEVLINE split. The same functionality is now possible with run-workflow-action.sh.
  • Remove create_patch_pr.sh and its associated patch.sh because they were hard-coded for the fddaq-v3(!) era and required manually editing a list of repos to submit patch PRs for.
  • Remove check-ci-status.sh because a) it assumed an obsolete release manifest format and b) we now have the workflow badges in the daq-release README

Other Updates

  • Bring check_if_patch_branch_exists.sh into the modern era (i.e., works with DEVLINE)
  • sync-ci-workflow-to-template.sh and trigger-or-disable-ci-all.sh are not executable on their own, but are meant to be sourced by run-workflow-action.sh
  • Additional error checking, e.g., complain if someone tries to sync a v4 workflow across develop branches
  • Implement a you're about to do X, proceed? line as an additional check

I tested these updates by replacing actual git commands with echo statements. Confirmed that error checking behaves as expected.

Copy link
Collaborator

@jcfreeman2 jcfreeman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge improvement over the current state of the continuous integration tools currently in the scripts/github-ci directory. I especially like all the checking for bad arguments, helpful error messages, etc.

@jcfreeman2 jcfreeman2 merged commit 94ae45f into develop Oct 18, 2024
1 check passed
@jcfreeman2 jcfreeman2 deleted the amogan/cleanup-github-ci-scripts branch October 18, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants