bugfix: Added default value for --run-type click option in cli.py #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bieryAtFnal
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests with the latest
nanorccode on theproduction/v4branch, I noticed complaints about failures in running the "lower" function on an empty object. I traced this to a lack of a default value in the --run-type option that I added tonanorcin cli.py recently. The code change in this PR fixes this bug.Before the change, we can not start runs with
nanorcwithout explicitly specifying the --run-type start/start_run parameter.With this change, a default value of "TEST" is assigned to the run_type and subsequent operations such as "lower" now work.