Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests including dune_services fail for dunecore in isolation #47

Open
dladams opened this issue Jan 14, 2023 · 1 comment
Open

Tests including dune_services fail for dunecore in isolation #47

dladams opened this issue Jan 14, 2023 · 1 comment
Assignees
@dladams @calcuttj @tomjunk
Labels
bug Something isn't working

Comments

@dladams
Copy link
Contributor

dladams commented Jan 14, 2023 •
edited
Loading

Testing dunecore agains larsoft (instead of dunesw as is normally done), I found that tests test_ChannelStatusServiceTool and test_issue19191 fail because they use dune_services.fcl which is in dunecore, but it includes simulationservices_dune.fcl which is not in dunecore or any of its dependencies.
@dladams dladams added the bug Something isn't working label Jan 14, 2023
@dladams
Copy link
Contributor Author

dladams commented Jan 14, 2023

Jake or Tom, can you let me know if the forward dependency problem in services_dune will be fixed?

If not I will change the tests to remove the implicit dependency on simulationservices_dune.fcl.

dladams pushed a commit that referenced this issue Jan 17, 2023
ToolBasedChannelStatusService now builds. #47
784ff23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dladams dladams

@calcuttj calcuttj

@tomjunk tomjunk

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dladams @calcuttj @tomjunk