LED calibration batch 2, DAQ timestamp and truncation development #64
+1,094
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some references to Waveform attributes had not been updated after the CamelCase to snake_case change
A reference to the Waveform class 'adcs' attribute had not been updated after the CamelCase to snake_case change
This change only affects the __build_waveforms_list_from_root_file_using_uproot() helper method of input/input_utils.py
This change only affects the __build_waveforms_list_from_root_file_using_pyroot() helper method of input/input_utils.py
The changes introduced to this docstring inform that now this function also reads a 'daq_timestamp' branch from the input ROOT file. The values read from such branch are loaded into the 'daq_window_timestamp' attribute of the instanced Waveform objects.
For the NP04 particular case, this functionality is needed when reading data coming from the APA 1, for which the length of the waveforms may not match. The cause for this is that WaveformSet requires its Waveform objects to be homogeneous in length.
marroyav
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests contain
Points 4 and 5 affect the HDF5 reader so feedback from Sam would be appreciated.
return WaveformSet()would also allow unifying the truncation-code.