Allow to add all directories with addDirectoryToBackup: [ "*" ]
#37
Conversation
- "*" in the additional directory to backup add all the server root directory. Some directory can still be excluded. This allow to save every directory except some. - People might want to save only some world, so I moved the world saves tasks in the 2nd for loop so that excluded directory are excluded from world to. - getDirectoryToBackup remove duplicate directory names if there is any. It might not matter at this point, but we should avoid duplicate directories if there is some before starting zip tasks.
|
I have found few minor bugs which should be fixed now. |
|
I have triied to do as few changes as possible so that every changes can be understoud. Let me know if you need more explanation about something or want any changes. |
|
Thank you for your additions! I am very happy to see new contributors and will review and implement your changes in near future |
|
Hi, let me know if there is thing that you would like me to change in this pr. |
|
I apologize for keeping you waiting so long. I've been very busy last few months and couldn't find time to do updates for the Backuper, but don't worry, I haven't abandoned it, I think I'll be back to work next week. Your PR is good, you don't need to change anything. |
|
Great, no problem. Take your time. |
|
Can I ask you to also add changes to the README to reflect these changes? |
|
Yes, I will add the info in the README in this pr. |
|
Thank you for your changes, I will merge it before the next release. I hope it is very soon) |
Hi thanks for this nice plugins. I was trying to save all my server files (excepts the backup folder), but I haven't found a way to add all of them without naming them 1 by 1.
I have triied to set
addDirectoryToBackup: [ "." ], it does include all my server files, but inside the parent directory. So I had theworld/duplicate in the .zip (container/world/andworld/)I would appreciate if "*" for all the root directories and files was working, so I'm trying to do it. (I will switch from draft request to pull request once I will have end my test)
Allow "*" as a path & remove excluded directories from worlds to.
Let me know if it's clear enough for you or if I need to change somethings.