You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We updated the permission registry in DXgovernance/dxdao-contracts#191 and as such need to change how we set permissions in the action builder.
Main changes:
No more relayer function in guilds itself - we need to directly call PermissionRegistry
We have split permissions for Eth (generic calls) and ERC20 permissions so these have to be called correctly
No more global any address
For assets tab we should make the default be any amount and disable the button for now. Later we will implement logic to add limits but it is slightly more complex requiring potentially two actions. We can also remove the "to address" input field. The way these permissions work is that we will set approve and transfer function calls to the token address.
For function call we should remove "Any address" from the "to" input. Then the default behaviour for value should be set to 0 and have "Max value" disabled.
We updated the permission registry in DXgovernance/dxdao-contracts#191 and as such need to change how we set permissions in the action builder.
Main changes:
For assets tab we should make the default be any amount and disable the button for now. Later we will implement logic to add limits but it is slightly more complex requiring potentially two actions. We can also remove the "to address" input field. The way these permissions work is that we will set approve and transfer function calls to the token address.
For function call we should remove "Any address" from the "to" input. Then the default behaviour for value should be set to 0 and have "Max value" disabled.
https://github.com/DXgovernance/dxdao-contracts/blob/develop/contracts/utils/PermissionRegistry.sol
https://rossneilson.notion.site/Permission-Registry-075bc158742a4a3898e6633afbe6c21f
The text was updated successfully, but these errors were encountered: