Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PermissionRegistry Action for new version #145

Closed
rossneilson opened this issue Jul 18, 2022 · 0 comments · Fixed by #199
Closed

Update PermissionRegistry Action for new version #145

rossneilson opened this issue Jul 18, 2022 · 0 comments · Fixed by #199
Assignees
Labels
enhancement New feature or request

Comments

@rossneilson
Copy link
Contributor

rossneilson commented Jul 18, 2022

We updated the permission registry in DXgovernance/dxdao-contracts#191 and as such need to change how we set permissions in the action builder.

Main changes:

  • No more relayer function in guilds itself - we need to directly call PermissionRegistry
  • We have split permissions for Eth (generic calls) and ERC20 permissions so these have to be called correctly
  • No more global any address

For assets tab we should make the default be any amount and disable the button for now. Later we will implement logic to add limits but it is slightly more complex requiring potentially two actions. We can also remove the "to address" input field. The way these permissions work is that we will set approve and transfer function calls to the token address.

For function call we should remove "Any address" from the "to" input. Then the default behaviour for value should be set to 0 and have "Max value" disabled.

https://github.com/DXgovernance/dxdao-contracts/blob/develop/contracts/utils/PermissionRegistry.sol

https://rossneilson.notion.site/Permission-Registry-075bc158742a4a3898e6633afbe6c21f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants