Refactor PermissionRegistry #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to remove permissions, owner can override permissionDelays, removed ERC20 and asset from permissions and allow only ETH functions and values to be used.
…d default allowed permissions Added functions to set the ERC20Limits by index in array owned by msg.sender, add function to set the initial value in block and check value transfered againts this value before call ends, also allowed calls to permission regsitry itself and internal calls by default but with no value
|
I want to add that this simplified the code to be deployed and reduced the code size.
|
|
fix #160 |
…r add/remove/executeRemove
…f doing calls from avatar
…sion values internallu
dcrescimbeni
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from -> to -> functionSignature -> permissionremoveERC20Limitand after the permission delay time passes the functionremoveERC20Limitcan be called publicly to effectively delete the permission, that space in the array can later be used by other ERC20 limit.So now everytime a proposal will execute the first thing that needs to be done is to call the permissionRegistry to save the balances of the tokens to be tracked, then the proposal executes only approved ETH functions and ETH transfers and once all executions are done the permissionRegistry is called to check the ERC20 values, if the difference between the initial value and the value after execution is higher than the allowed, the proposal would revert.