Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontrunning Proposal Execution #160

Closed
rossneilson opened this issue Jun 13, 2022 · 2 comments
Closed

Frontrunning Proposal Execution #160

rossneilson opened this issue Jun 13, 2022 · 2 comments
Labels
Milestone

Comments

@rossneilson
Copy link
Collaborator

Screenshot 2022-06-13 at 12 30 45

@rossneilson rossneilson added this to the Guilds v1.0.0 milestone Jun 13, 2022
@rossneilson rossneilson moved this to Backlog in Sprints Jun 13, 2022
@AugustoL AugustoL modified the milestones: Guilds v1.0.0, v1.1.0 Jun 13, 2022
@AugustoL AugustoL self-assigned this Jun 14, 2022
@dcrescimbeni dcrescimbeni self-assigned this Jun 24, 2022
@dcrescimbeni dcrescimbeni moved this from Backlog to In Progress in Sprints Jun 25, 2022
@AugustoL
Copy link
Member

AugustoL commented Jul 4, 2022

fixed in #191

Repository owner moved this from In Progress to Done in Sprints Jul 20, 2022
@rossneilson rossneilson reopened this Aug 30, 2022
@rossneilson
Copy link
Collaborator Author

This was marked as still open by the auditing team. To avoid this frontrunning we would have to require from === msg.sender

Screenshot 2022-08-30 at 09 56 31

@rossneilson rossneilson moved this from Done to Backlog in Sprints Aug 30, 2022
@github-project-automation github-project-automation bot moved this from Backlog to Done in Sprints Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants