Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/DOS on withdrawal tokens #179

Merged

Conversation

dcrescimbeni
Copy link
Contributor

Closes issue #149, according to finding DXD-01 of the Sigma Prime audit.

Added checks for tokenAmount to be greater than zero, and made accompanying tests.

@dcrescimbeni dcrescimbeni marked this pull request as ready for review June 16, 2022 18:38
rossneilson
rossneilson previously approved these changes Jun 17, 2022
AugustoL
AugustoL previously approved these changes Jun 20, 2022
@dcrescimbeni dcrescimbeni dismissed stale reviews from AugustoL and rossneilson via be1532a June 20, 2022 14:18
@rossneilson rossneilson merged commit c284fc7 into DXgovernance:develop Jun 21, 2022
@dcrescimbeni dcrescimbeni deleted the fix/dos-on-withdrawalTokens branch October 24, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants