Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/create proposal with zero totallocked #182

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Fix/create proposal with zero totallocked #182

merged 5 commits into from
Jul 1, 2022

Conversation

MiltonTulli
Copy link
Member

@MiltonTulli MiltonTulli commented Jun 17, 2022 •
edited
Loading

  • Modify BaseERC20 setConfig function to accept new minimumMembersForProposalCreation and minimumTokensLockedForProposalCreation
  • Add minimum members validation before create proposal
  • Add minimum tokensLocked validation before create proposal
  • Include tests and fix previous setConfig signatures

Closes #158

@MiltonTulli MiltonTulli marked this pull request as draft June 17, 2022 15:28
@MiltonTulli MiltonTulli marked this pull request as ready for review June 21, 2022 23:19
@MiltonTulli MiltonTulli changed the title [WIP] Fix/create proposal with zero totallocked Fix/create proposal with zero totallocked Jun 21, 2022
@MiltonTulli MiltonTulli requested a review from AugustoL June 21, 2022 23:19
rossneilson
rossneilson previously approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@rossneilson rossneilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good. I am still not convinced this really accomplishes much but if it satisfies the report and Augusto think its worthwhile then lets add it.

AugustoL
AugustoL requested changes Jun 28, 2022
View reviewed changes
contracts/erc20guild/ERC20GuildUpgradeable.sol Outdated Show resolved Hide resolved
contracts/erc20guild/ERC20Guild.sol Outdated Show resolved Hide resolved
@MiltonTulli MiltonTulli requested a review from AugustoL June 29, 2022 14:29
@MiltonTulli MiltonTulli force-pushed the fix/create-proposal-with-zero-totallocked branch from 50618aa to a94848e Compare June 29, 2022 14:55
@MiltonTulli MiltonTulli requested a review from rossneilson June 29, 2022 14:57
@rossneilson rossneilson merged commit 090e02d into DXgovernance:develop Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossneilson rossneilson rossneilson approved these changes

@AugustoL AugustoL AugustoL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiltonTulli @AugustoL @rossneilson