New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update internal state before external call #195

Merged

0xvangrim merged 1 commit into DXgovernance:develop from 0xvangrim:state-changes-external-calls

Jul 7, 2022

Contributor

0xvangrim commented Jul 6, 2022

Issue: #177

update the internal state before making the external call (to protect against re-entry attacks)
Tests are covered in DXDVotingMachine.js


          fix: update internal state before external call

1c140d1

0xvangrim requested review from AugustoL, mprasanjith, MiltonTulli, rossneilson and dcrescimbeni

July 6, 2022 12:20

AugustoL approved these changes

View reviewed changes

rossneilson approved these changes

View reviewed changes

0xvangrim merged commit 67b288e into DXgovernance:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rossneilson rossneilson approved these changes

AugustoL AugustoL approved these changes

mprasanjith Awaiting requested review from mprasanjith

MiltonTulli Awaiting requested review from MiltonTulli

dcrescimbeni Awaiting requested review from dcrescimbeni

Labels

None yet