Final refactor to dxdao gov 1.5 contracts #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all Governance 1.5 contracts to dxdao folder, upgrade all solc versions to math 0.8.8, do necessary changes in the contracts to bundle all them together and execute proposals (mostly changes in WalletSchemes, Voting machine and a bit on avatar, controller and reputation)
|
Should we take this opportunity whilst upgrading to remove safe math? |
|
Nice change to contract names from DX -> DAO, next step is getting everyone using our contracts! |
…hange needed ones Only use solidity version 0.8.17, done necessary changes in all contracts to use this version, removed the old openzeppelin-solidity contracts, removed not needed GnosisProxya nd some old tests contracts used for daostack.
…alletScheme and AvatarScheme
…tScheme.initialize
…time fails- positive decision - proposal fails
…ts into gov-1-5-contracts
…ng schemes Since the register scheme can register schemes, we assume that it has complete control over the dao and we wont use the AvatarScheme as RegistrarScheme, so since we dont use avatar calls we cant require the registrar schemes to do avatar calls
… RegistrarScheme test
…g machine hold staking tokens
…ts into gov-1-5-contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to implement a dynamic amount of options to be used in the WalletScheem cause the DXDVotingMachine is heavily designed to work with only two options. The WalletScheme is designed to work with multiple options anyway, but for now we require only two options to be used. Later when we work on the Gov 2.0 voting machine we can design it to work with multiple options.