Scheme refactor #254
Merged
Scheme refactor #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprasanjith
requested review from
AugustoL,
MiltonTulli,
rossneilson,
0xvangrim and
dcrescimbeni
…tiple options by default Add smart contract description, implement executeProposal function with multiple options execution
…e proposals exec and submission Override function to propose and execute proposals to enforce only two options to be used and execute all calls when winning option is one
… bugfix/scheme-fixes
AugustoL
approved these changes
Nov 7, 2022
…roposal is marked as rejected Refactor the execution of proposals in Scheme, now a proposal is marked as rejected if the calls batch executed are just empty calls (calls to address 0 and value 0). The WalletScheme was changed requiring the second half of the proposals submitted to be empty, this means that for option 2 it will mark the proposal as rejected, since the second half of the calls are just empty calls.
… bugfix/scheme-fixes
… bugfix/scheme-fixes
MiltonTulli
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #240 and #241.
Description
Scheme.solfromWalletSchemetoScheme.Schemeto inheritedWalletSchemeandAvatarSchemecontracts.