Fix/add dxdvotingmachine interface in Scheme - S4 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or propose function
AugustoL
force-pushed
the
fix/add-dxdvotingmachine-interface
branch
from
b02f67e to
d24f81f
Compare
dcrescimbeni
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call on line 164 to the propose function of the voting machine is done using functionCall instead
of calling the propose function directly. The code will be more readable and gas efficient by just calling
the propose function:
proposalId = IVotingMachine(votingMachine).propose(_totalOptions, ...)Recommendation: Replace the use of functionCall by calling the propose function of the voting
machine directly.