Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Schemes: increased coverage, replaced SafeMath and added custom errors #262

Merged
merged 31 commits into from
Nov 11, 2022
Merged

Refactor Schemes: increased coverage, replaced SafeMath and added custom errors #262

merged 31 commits into from
Nov 11, 2022

Conversation

dcrescimbeni
Copy link
Contributor

@dcrescimbeni dcrescimbeni commented Nov 8, 2022 •
edited
Loading

  • Increased Scheme, AvatarScheme and WalletScheme coverage
  • Removed SafeMath [G2]
  • Replaced require with custom errors [G1]

Coverage report
image

@dcrescimbeni
test(AvatarScheme.js): added tests for getFunctionSignature method
8200038
@dcrescimbeni
fix(AvatarScheme): changed require messages that referenced WalletSch…
0f84785 
…eme for AvatarScheme
@dcrescimbeni
test(AvatarScheme): added tests for getting the amount of proposals a…
e7302c6 
…nd setting maxSecondsForExecution
@dcrescimbeni
test(AvatarScheme): added test for ExecutionTimeout and getSchemeType
57b9806
@dcrescimbeni
test(WalletScheme): added test to get scheme type
f0b2e80
@dcrescimbeni
feat(constants): added MIN_SECONDS_FOR_EXECUTION constant
1325d33
@dcrescimbeni
test(WalletScheme): removed .only from test
66197b5
@dcrescimbeni
refactor(AvatarScheme): removed SafeMath
651c972
@dcrescimbeni
refactor(AvatarScheme): replacing required with custom errors (WIP)
40f335c
@dcrescimbeni
fix: merge
20f420f
@dcrescimbeni
refactor(AvatarScheme): replaced require with custom errors
b7d3108
@dcrescimbeni
fix(AvatarScheme): removed console.log and .only
236959b
@dcrescimbeni
test(DAOController): skipped failing tests
f391beb
@dcrescimbeni
refactor(WalletScheme): replaced required with custom errors
be39fd0
@dcrescimbeni dcrescimbeni changed the base branch from main to refactor-dxdao-contracts November 8, 2022 20:49
@dcrescimbeni dcrescimbeni changed the title [WIP] Refactor: increased coverage, replaced SafeMath and added custom errors Refactor: increased coverage, replaced SafeMath and added custom errors Nov 8, 2022
@dcrescimbeni dcrescimbeni marked this pull request as ready for review November 8, 2022 22:11
@dcrescimbeni dcrescimbeni marked this pull request as draft November 9, 2022 20:17
@dcrescimbeni
Copy link
Contributor Author

Fixed merge conflicts and updated tests.

Marked this as "Draft" to work on increasing branch coverage.

@dcrescimbeni dcrescimbeni marked this pull request as ready for review November 10, 2022 19:44
@AugustoL AugustoL changed the title Refactor: increased coverage, replaced SafeMath and added custom errors Refactor Schemes: increased coverage, replaced SafeMath and added custom errors Nov 11, 2022
@dcrescimbeni dcrescimbeni merged commit 1dc0a79 into DXgovernance:refactor-dxdao-contracts Nov 11, 2022
@dcrescimbeni dcrescimbeni deleted the fix/schemes-various-fixes branch November 11, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustoL AugustoL AugustoL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcrescimbeni @AugustoL