Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schemes & VotingMachine fixes #270

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Schemes & VotingMachine fixes #270

merged 3 commits into from
Nov 22, 2022

Conversation

MiltonTulli
Copy link
Member

@MiltonTulli MiltonTulli commented Nov 21, 2022 •
edited
Loading

Description

  • Fix walletScheme failing test
  • Scheme: Clean unused error definitions & refactor require statements with custom error
  • Refactor VotingMachine to use custom errors

@MiltonTulli MiltonTulli changed the title [WIP] Fixes DaoContracts fixes Nov 21, 2022
@MiltonTulli MiltonTulli requested a review from AugustoL November 21, 2022 22:46
@MiltonTulli MiltonTulli changed the title DaoContracts fixes Schemes & VotingMachine fixes Nov 21, 2022
@MiltonTulli MiltonTulli merged commit 78ea89a into DXgovernance:refactor-dxdao-contracts Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustoL AugustoL AugustoL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiltonTulli @AugustoL