-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dao contracts documentation #274
Merged
MiltonTulli
merged 14 commits into
DXgovernance:v2.0
from
MiltonTulli:feaure/1.5-documentation
Nov 30, 2022
Merged
Dao contracts documentation #274
MiltonTulli
merged 14 commits into
DXgovernance:v2.0
from
MiltonTulli:feaure/1.5-documentation
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiltonTulli
force-pushed
the
feaure/1.5-documentation
branch
from
November 29, 2022 15:46
a9b681d
to
c374593
Compare
MiltonTulli
commented
Nov 30, 2022
AugustoL
requested changes
Nov 30, 2022
* @dev getProposalScheme return the schemeId for a given proposal | ||
* @param _proposalId the ID of the proposal | ||
* @return bytes32 scheme identifier | ||
* @dev Return the schemeId for a given proposal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReturnS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed all "return" typos. Than you
AugustoL
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve
DAOController
,DAOAvatar
,DAOReputation
,DXDVotingMachine
&Scheme
contracts documentation.Refactor comments, arguments, and returns definitions.
https://github.com/MiltonTulli/dxdao-contracts/blob/feaure/1.5-documentation/docs/SUMMARY.md