Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v2 refactor issues #279

Merged
merged 5 commits into from
Dec 5, 2022
Merged

Fix v2 refactor issues #279

merged 5 commits into from
Dec 5, 2022

Conversation

AugustoL
Copy link
Member

@AugustoL AugustoL commented Dec 5, 2022 •
edited
Loading

  • Add missing _snapshot call in the burnMultiple and mintMultiple DAOReputation functions.
  • Remove duplicated call to endProposal in AvatarScheme.
  • Remove not wanted allowance for owner to setETHPermissionUsed in PermissionRegistry.
  • Remove the reputation reward for creation of proposals in the VotingMachine, we dont use it in dxdao, and in case we want we will add a call for it if the scheme is allowed to mint rep on the proposal calls.
  • Rename DXDVotingMachineCallsbacksInterface to IDXDVotingMachineCallbacks

@AugustoL AugustoL merged commit f149a60 into DXgovernance:v2.0 Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiltonTulli MiltonTulli MiltonTulli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AugustoL @MiltonTulli